Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Need to bump revm-inspectors to 0.7.4 #8895

Closed
2 tasks
iajoiner opened this issue Sep 18, 2024 · 0 comments · Fixed by #8902
Closed
2 tasks

bug: Need to bump revm-inspectors to 0.7.4 #8895

iajoiner opened this issue Sep 18, 2024 · 0 comments · Fixed by #8902
Labels
T-bug Type: bug

Comments

@iajoiner
Copy link

iajoiner commented Sep 18, 2024 •
edited
Loading

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

d663f38

What command(s) is the bug in?

CI in a downstream project

Operating System

None

Describe the bug

alloy made a breaking change about 5 hours ago without bumping the major version, breaking downstream crates such as revm-inspectors which we use. revm-inspectors was fixed about 3 hours ago which can be accessed by bumping it to 0.7.4. If we bump this dependency to 0.7.4 it will probably fix the issue.
@iajoiner iajoiner added T-bug Type: bug T-needs-triage Type: this issue needs to be labelled labels Sep 18, 2024
@iajoiner iajoiner changed the title Need to bump revm-inspectors to 0.7.4 bug: Need to bump revm-inspectors to 0.7.4 Sep 18, 2024
This was referenced Sep 18, 2024
Closed
Merged
JayWhite2357 added a commit to spaceandtimelabs/sxt-proof-of-sql that referenced this issue Sep 18, 2024
@JayWhite2357
fix: temporarily disable solidity tests (#166)
44e9e98 
# Rationale for this change
See alloy-rs/alloy#1307 and
foundry-rs/foundry#8895 for the background.

# What changes are included in this PR?
Disable solidity tests

# Are these changes tested?
Existing tests do pass
@yash-atreya yash-atreya mentioned this issue Sep 19, 2024
Merged
@yash-atreya yash-atreya removed the T-needs-triage Type: this issue needs to be labelled label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-bug Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: bump alloy 0.3.6 foundry-rs/foundry
fix: bump revm-inspectors to 0.7.4 iajoiner/foundry
2 participants
@iajoiner @yash-atreya