Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no unauthorized error thrown if resource id is invalid #165

Open
m4v15 opened this issue Oct 14, 2017 · 0 comments
Open

no unauthorized error thrown if resource id is invalid #165

m4v15 opened this issue Oct 14, 2017 · 0 comments
Labels

Comments

@m4v15
Copy link
Collaborator

m4v15 commented Oct 14, 2017

if the resource Id in the URL is invalid it now gets thrown here (when the trying to access the resource to identify the owner) so it doesn't throw an unauthorised error, even if the user is unauthorised (as this happens before it is certain if the user is authed or not).

I actually guess that's not a problem, but it just made rewriting the tests confusing for a bit so just wanted to flag it up.

We may also now have some unnecessary error messages/uses of them in the controllers.

@m4v15 m4v15 added the question label Oct 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant