Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add views relating to auth and OAuth #104

Open
3 of 5 tasks
mattlub opened this issue Aug 15, 2017 · 5 comments
Open
3 of 5 tasks

add views relating to auth and OAuth #104

mattlub opened this issue Aug 15, 2017 · 5 comments
Assignees
Milestone

Comments

@mattlub
Copy link
Collaborator

mattlub commented Aug 15, 2017

high priority:

  • login (GET /login)
  • register (GET /register)
    • check the User model for required fields
  • authorise app (GET /oauth/authorize)
    • query params client_id, redirect_uri, state (iirc- check them)
    • renders page specific to the client (app)

lower priority:

  • register app (GET /oauth/register-app)
    • requires authentication
    • check the Client model for required fields
  • my apps
    • requires authentication

@des-des @m4v15 thoughts on the endpoints I've suggested?

@mattlub mattlub added this to the Sprint 3 milestone Aug 15, 2017
@mattlub mattlub mentioned this issue Aug 15, 2017
10 tasks
@mattlub mattlub self-assigned this Aug 15, 2017
@mattlub mattlub mentioned this issue Aug 15, 2017
3 tasks
@m4v15
Copy link
Collaborator

m4v15 commented Aug 15, 2017

@jwld @mattlub Just wanted to make you aware that currently, the post request to /register expects a particular kind of body, like this:

    const { englishName, arabicName, email, username, imageUrl } = req.body
    const en = englishName && { name: englishName }
    const ar = arabicName && { name: arabicName }
    return Users.create(Object.assign(
      {
        username: username,
        password: passwordHash,
        role: roles.BASIC,
        email: email,
        imageUrl: imageUrl
      },
      { ar },
      { en }
    ))

we can allow for organisation name as englishOrgNam and arabicOrgName (didn't do it originally but am going to do it before the PR is finished

@m4v15
Copy link
Collaborator

m4v15 commented Aug 15, 2017

Those endpoints look good to me - you know what each form is POST ing to as well yeah?

@m4v15
Copy link
Collaborator

m4v15 commented Aug 15, 2017

Are we going to get rid of the user endpoints on the API?

Or I guess we always said we'd just secure these for only SUPER

@des-des
Copy link
Member

des-des commented Aug 16, 2017

@mattlub they look good.

This was referenced Aug 21, 2017
@des-des
Copy link
Member

des-des commented Sep 6, 2017

scope done for this sprint

@des-des des-des modified the milestones: Backlog, Sprint 3 Sep 6, 2017
@m4v15 m4v15 modified the milestones: Backlog, Sprint 4 Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants