Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove coords from MoleculeSetups in Meeko #143

Closed
psharma-sr opened this issue Jul 26, 2024 · 2 comments
Closed

Remove coords from MoleculeSetups in Meeko #143

psharma-sr opened this issue Jul 26, 2024 · 2 comments
Assignees
Labels
refactor Improvements to the code without necessarily adding features

Comments

@psharma-sr
Copy link

Evaluate if coords can be eliminated from MoleculeSetups and remove them if possible.

@psharma-sr psharma-sr added the refactor Improvements to the code without necessarily adding features label Jul 26, 2024
@psharma-sr psharma-sr added this to the Meeko Refactoring Project milestone Jul 26, 2024
@psharma-sr psharma-sr self-assigned this Jul 26, 2024
@diogomart
Copy link
Contributor

@mallanos and @mattholc weren't as enthusiastic about this as me and @nbruciaferri, so we decided to not separate the coordinates from the molsetups, unless it really is necessary to address #131

@diogomart
Copy link
Contributor

Arguments in favor of separating coords from molsetups:

  • similarity to the design of openmm (topology and positions are separate) and RDKit (conformer objects are option in molecule objects)
  • docking results are small trajectories
  • could parameterize molecules without calculating their 3D coordinates

Against:

  • not enough use cases for coord-less (pun not intended) molsetups to justify the risk of API user mistakes when molsetup and coords can be manipulated separately
  • the positions of CG/G pseudo atom and generally offsite atoms depend on the positions of other atoms, even though this already partially mitigated because calculating the positions of offsite atoms is a two step process and the first step does not depend on coordinates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Improvements to the code without necessarily adding features
Projects
None yet
Development

No branches or pull requests

2 participants