Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mock-fs is incompatible with Node v20 #592

Open
jmsjtu opened this issue Jul 1, 2024 · 1 comment · Fixed by #593
Open

mock-fs is incompatible with Node v20 #592

jmsjtu opened this issue Jul 1, 2024 · 1 comment · Fixed by #593

Comments

@jmsjtu
Copy link
Collaborator

jmsjtu commented Jul 1, 2024

Summary

The mock-fs package is incompatible with Node v20, which causes unit tests in the aura-language-server and lightning-lsp-common to fail.

It looks like there's a draft PR in mock-fs to support Node v20 but progress seems to be slow.

A potential replacement is memfs, although there's some extra plumbing that needs to happen to make it compatible with existing tests.

Steps To Reproduce:

  1. Install node v20
  2. Run unit tests

Expected result

No test failures

Actual result

Test failures
@jmsjtu jmsjtu mentioned this issue Jul 1, 2024
Merged
@jmsjtu jmsjtu reopened this Jul 1, 2024
@jmsjtu
Copy link
Collaborator Author

jmsjtu commented Jul 1, 2024

The fix introduced in #593 is a temporary work-around to unblock other PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: pin ci to node v18 forcedotcom/lightning-language-server
1 participant
@jmsjtu