Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[googlefonts/article/images] detect relative image paths #4848

Open
vv-monsalve opened this issue Oct 3, 2024 · 0 comments
Open

[googlefonts/article/images] detect relative image paths #4848

vv-monsalve opened this issue Oct 3, 2024 · 0 comments
Labels
Check improvement proposal GF's priority list List of high priority issues for google/fonts CI

Comments

@vv-monsalve
Copy link
Collaborator

Observed behavior

A PR failed to be pushed due to the presence of relative image paths, causing a break in the Dev server.

Expected behavior

The check should detect if these paths are present in the metadata file.

Log level result: ☠️ Fatal

Resources and steps needed to reproduce

Original PR introducing the situation
PR to solve the situation, made by Rod.
@vv-monsalve vv-monsalve added Check improvement proposal GF's priority list List of high priority issues for google/fonts CI labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Check improvement proposal GF's priority list List of high priority issues for google/fonts CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vv-monsalve