Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for dist/mark shaping order? #4784

Open
davelab6 opened this issue Jul 10, 2024 · 2 comments
Open

Add check for dist/mark shaping order? #4784

davelab6 opened this issue Jul 10, 2024 · 2 comments
Assignees
@simoncozens
Labels
New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id P1 Quick Profile: Open Type Checks are separated in one sub-profile for each of the Open Type tables

Comments

@davelab6
Copy link
Contributor

A font developer wrote me privately that

Noto Sans Siddham in recent versions have GPOS 'dist' after 'mark', which for non-HarfBuzz engines means any attachments can become separated. In this particular case it seemed like 'dist' could just as easily be the first lookup without breaking anything, maybe this is a sanity check that could be applied?

I defer to @simoncozens on if this can be a fb check but it seems plausible :)
@davelab6 davelab6 added P1 Quick New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id Profile: Open Type Checks are separated in one sub-profile for each of the Open Type tables labels Jul 10, 2024
@khaledhosny
Copy link
Contributor

This should include kern feature as well.

@simoncozens
Copy link
Collaborator

I think this is not the right check. Let me hash it out with you and that font developer privately, since I'm aware they can't use GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simoncozens simoncozens

Labels
New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id P1 Quick Profile: Open Type Checks are separated in one sub-profile for each of the Open Type tables
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@khaledhosny @simoncozens @davelab6