Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix code-testing involving @cff_analysis condition #4771

Open
felipesanches opened this issue Jun 20, 2024 · 0 comments
Open

fix code-testing involving @cff_analysis condition #4771

felipesanches opened this issue Jun 20, 2024 · 0 comments

Comments

@felipesanches
Copy link
Collaborator

felipesanches commented Jun 20, 2024

While porting the new check com.adobe.fonts/check/cff_ascii_strings from OpenBakery (issue #4619), I left a test-case commented out because the cff_analysis condition is ignoring changes made to the ttFont object on a code-test.

The reason for that is that a new fonttools.ttLib.TTFont object is created based on the original file, which effectively discards any changes made by the code-test prior to invoking the check.

a326e75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant