Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] fix feast jupyter notebook #4455

Open
2 tasks done
Tracked by #5783
samhita-alla opened this issue Nov 20, 2023 · 7 comments
Open
2 tasks done
Tracked by #5783

[Docs] fix feast jupyter notebook #4455

samhita-alla opened this issue Nov 20, 2023 · 7 comments
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest pri3

Comments

@samhita-alla
Copy link
Contributor

Description

the minio URL used in the feast notebook needs to be updated to http://localhost:30002. additionally, the end-to-end example should undergo thorough testing to ensure it is working properly.

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@samhita-alla samhita-alla added documentation Improvements or additions to documentation pri3 labels Nov 20, 2023
@manishdait
Copy link

Hi @davidmirror-ops, I would like to work on these issue

@davidmirror-ops
Copy link
Contributor

@manishdait thanks for participating! Let us know soon if you have questions.

@manishdait
Copy link

Can you provide me a little bit more info regarding the issue

@davidmirror-ops
Copy link
Contributor

I think it refers to the contents here

If I remember correctly, the idea is to align it to the port the minio instance uses on the flyte sandbox, is that correct @samhita-alla ?

@samhita-alla
Copy link
Contributor Author

@davidmirror-ops that's correct. the issue also includes ensuring that the example works by running it on flyte sandbox.

@manishdait
Copy link

Hey @davidmirror-ops , I have raise the PR for the issue can you please review it, and suggest me changes if any require.
[https://github.com/flyteorg/flytesnacks/pull/1737](Pull Request)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest pri3
Projects
None yet
Development

No branches or pull requests

3 participants