Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Remove ignore: deprecated_member_use and adopt nonlinear text scaling #983

Open
1 task done
LongCatIsLooong opened this issue Jul 21, 2023 · 0 comments
Open
1 task done
Labels
enhancement New feature or request P2 Priority 2 - Should have

Comments

@LongCatIsLooong
Copy link
Contributor

Existing issue?

What happened?

2 ignore: deprecated_member_use were added in #982 to temporarily address textScaleFactor deprecation. They should be removed and the codebase should switch to using TextScaler instead.

Currently some UI components are scaled by text scale factor (an example:

20 * textScaleFactor / 2
: 175 + 140 * textScaleFactor / 2,
) which may not work as well with nonlinear text scaling, as the text scaling curve isn't designed to scale non-textual contents (e.g. it may not work well when the dimension is not in the typical font size range).

Relevant log output

No response

@LongCatIsLooong LongCatIsLooong added enhancement New feature or request triage labels Jul 21, 2023
@guidezpl guidezpl added P2 Priority 2 - Should have and removed triage labels Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request P2 Priority 2 - Should have
Projects
None yet
Development

No branches or pull requests

2 participants