Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text going under custom window commands #341

Merged
merged 2 commits into from
Sep 17, 2016

Conversation

chrfin
Copy link
Contributor

@chrfin chrfin commented Aug 24, 2016

I use something like the following in my app:

<fluent:RibbonWindow.WindowCommands>
    <fluent:WindowCommands x:Name="WindowCommandsTitle">
        <StackPanel x:Name="StackPanelWindowCommands" Orientation="Horizontal" Margin="0 0 10 0" Visibility="{Binding Visibility}">
            <Button x:Name="buttonTitlebarSettings" Command="{Binding SettingsCommand}" Visibility="{Binding SettingsVisibility}"
                    Style="{DynamicResource Styles.Button.WindowChrome}" ToolTip="{lex:Loc Options}">
                <Image Source="{DynamicResource Icons.Gray.Settings}" Style="{DynamicResource Styles.Images.Button.WindowChrome}" />
            </Button>
            <Button x:Name="buttonTitlebarInfo" Command="{Binding InfoCommand}" Visibility="{Binding InfoVisibility}"
                    Style="{DynamicResource Styles.Button.WindowChrome}" ToolTip="{lex:Loc About}">
                <Image Source="{DynamicResource Icons.Gray.Info}" Style="{DynamicResource Styles.Images.Button.WindowChrome}" />
            </Button>
            <Button x:Name="buttonTitlebarHelp" Command="{Binding HelpCommand}" Visibility="{Binding HelpVisibility}"
                    Style="{DynamicResource Styles.Button.WindowChrome}" ToolTip="{lex:Loc Help}">
                <Image Source="{DynamicResource Icons.Gray.Question}" Style="{DynamicResource Styles.Images.Button.WindowChrome}" />
            </Button>
        </StackPanel>
    </fluent:WindowCommands>
</fluent:RibbonWindow.WindowCommands>

This in combination with a very long file name added to the window title causes this:
image

I think the reason is the "overlapping controls". I now moved the window commands to its own column to avoid this.

@batzen
Copy link
Member

batzen commented Sep 10, 2016

Will try to have a look at this. I am very busy at the moment...

@batzen batzen merged commit 63a13f6 into fluentribbon:develop Sep 17, 2016
@batzen batzen added this to the 5.0.0 milestone Sep 17, 2016
@chrfin chrfin deleted the develop branch March 13, 2017 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants