Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyTips in SplitButton no longer work #200

Closed
floele-ww opened this issue Nov 17, 2015 · 2 comments
Closed

KeyTips in SplitButton no longer work #200

floele-ww opened this issue Nov 17, 2015 · 2 comments
Assignees
Labels
Milestone

Comments

@floele-ww
Copy link
Contributor

Consider the following SplitButton:

                <Fluent:SplitButton Header="Test KeyTips" Fluent:KeyTip.Keys="Y">
                    <Fluent:MenuItem Fluent:KeyTip.Keys="A"  Header="1" />
                    <Fluent:MenuItem Fluent:KeyTip.Keys="B" Header="2" />
                    <Fluent:MenuItem Fluent:KeyTip.Keys="C" Header="3" />
                </Fluent:SplitButton>

If you open it using KeyTips, the menu will look like this:
keytipsmissing

Expected would be this (this is what a dropdown button looks like):
keytips

Reason seems to be that KeyTipAdorner.Forward() also includes the SplitButton's ToggleButton at

 var children = LogicalTreeHelper.GetChildren(element)

which is then used to create the KeyTipAdorner. Not sure how the solution should work though.

@batzen
Copy link
Member

batzen commented Nov 17, 2015

You are totally right.
Will change the order in which SplitButtons returns it's logical children, or even better just call base.LogicalChildren in SplitButton.

@batzen batzen self-assigned this Nov 18, 2015
@batzen batzen added this to the 3.6.1 milestone Nov 18, 2015
@batzen batzen closed this as completed in 23e574c Nov 18, 2015
@floele-ww
Copy link
Contributor Author

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants