Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headings in the toolbar don't make use of the styles defined by FleatherTheme #423

Open
kane-knowby opened this issue Sep 11, 2024 · 1 comment
Labels
bug Something isn't working waiting for user feedback

Comments

@kane-knowby
Copy link

Steps to Reproduce

  1. Wrap your FleatherToolbar with a FleatherTheme
  2. Observe heading styles are not reflected when choosing a heading from toolbar
  3. Specifically heading 5 is always underlined which is main problem for us

Environment

OS: iOS/Web/Android
Flutter version: 3.24
Fleather version: 1.18.0

@amantoux amantoux added the bug Something isn't working label Sep 21, 2024
@amantoux
Copy link
Member

amantoux commented Sep 24, 2024

@kane-knowby Can you please post a code sample to reproduce? I wasn't able to reproduce on my end with the following

return FleatherTheme(
  data: FleatherThemeData.fallback(context).copyWith(heading5: TextBlockTheme(
    style: DefaultTextStyle.of(context).style.copyWith(fontSize: 10),
    spacing: const VerticalSpacing.zero(),
  )), 
  child: Column(
    children: [
      FleatherToolbar.basic(controller: _controller!, editorKey: _editorKey),
      Divider(height: 1, thickness: 1, color: Colors.grey.shade200),
      Expanded(
        child: FleatherEditor(
          controller: _controller!,
          focusNode: _focusNode,
          editorKey: _editorKey,
        ),
      ),
     ],
   ),
);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working waiting for user feedback
Projects
None yet
Development

No branches or pull requests

2 participants