Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separators in the toolbar should be hidden if all buttons on their left/right are hidden #330

Open
maelchiotti opened this issue Apr 28, 2024 · 0 comments
Open

Separators in the toolbar should be hidden if all buttons on their left/right are hidden #330

maelchiotti opened this issue Apr 28, 2024 · 0 comments
Labels
enhancement New feature or request toolbar Issue related to FleatherToolbar

Comments

@maelchiotti
Copy link
Contributor

maelchiotti commented Apr 28, 2024 •
edited
Loading

Steps to Reproduce

  1. Use the basic toolbar
  2. Set hideUndoRedo to true
  3. Scroll the toolbar all the way to the right

I guess this happens on the left side also.

I saw in the code that there is already some logic to hide separators, but it seems to miss some cases as this one.

Screenshot_2024-04-28-11-46-26-428-edit_com.maelchiotti.localmaterialnotes.jpg

Environment

  • OS: Android
  • Flutter version: 3.19.3
  • Fleather version: 1.14.4
@amantoux amantoux added the enhancement New feature or request label Apr 30, 2024
@amantoux amantoux added the toolbar Issue related to FleatherToolbar label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request toolbar Issue related to FleatherToolbar
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amantoux @maelchiotti