Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missed removal of real dtypes #560

Open
janden opened this issue Sep 11, 2024 · 2 comments
Open

Missed removal of real dtypes #560

janden opened this issue Sep 11, 2024 · 2 comments
Assignees

Comments

@janden
Copy link
Collaborator

janden commented Sep 11, 2024

Looking through finufft._interfaces, I found that we were supposed to remove the possibility of real dtypes in 2.3:

if dtype == np.float64:
warnings.warn("Real dtypes are currently deprecated and will be "
"removed in version 2.3. Converting to complex128.",
DeprecationWarning)
dtype = np.complex128
if dtype == np.float32:
warnings.warn("Real dtypes are currently deprecated and will be "
"removed in version 2.3. Converting to complex64.",
DeprecationWarning)
dtype = np.complex64

Same applies to cufinufft._plan:

if self.dtype == np.float64:
warnings.warn("Real dtypes are currently deprecated and will be "
"removed in version 2.3. Converting to complex128.",
DeprecationWarning)
self.dtype = np.complex128
if self.dtype == np.float32:
warnings.warn("Real dtypes are currently deprecated and will be "
"removed in version 2.3. Converting to complex64.",
DeprecationWarning)
self.dtype = np.complex64

We should probably go back and do this for 2.4 and 2.3.X.

@ahbarnett
Copy link
Collaborator

Good idea!

@ahbarnett
Copy link
Collaborator

@janden any chance you can attend to this quick one? Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants