Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isCA check error, noticed when using typescript #30

Open
agmcleod opened this issue Jan 10, 2022 · 0 comments
Open

isCA check error, noticed when using typescript #30

agmcleod opened this issue Jan 10, 2022 · 0 comments

Comments

@agmcleod
Copy link

agmcleod commented Jan 10, 2022

I think the line here:

!pem.extensions.isCA &&
is incorrect. I've been pulling in some of this code into a demo/prototype project. I'm using typescript, and was able to reference the types for the x509 package. The typescript compiler noted how isCA is not a field on the Extension[] field. I think this can be changed to use the isCA field on the pem object instead. The library sifts through the extensions and updates the boolean based on what it finds here: https://github.com/fidm/x509/blob/master/src/x509.ts#L393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant