Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail, CI not running #5

Open
kacperzuk-neti opened this issue May 16, 2024 · 0 comments
Open

Tests fail, CI not running #5

kacperzuk-neti opened this issue May 16, 2024 · 0 comments

Comments

@kacperzuk-neti
Copy link
Collaborator

Currently tests fail with:

> @fidlabs/[email protected] test
> jasmine-ts --config=jasmine.json

tests/checker/TestSetup.ts:66:3 - error TS2322: Type '{ committerName: string; repo: string; branch: string; committerEmail: string; owner: string; searchRepo: string; searchRepoLarge: string; }' is not assignable to type 'FileUploadConfig'.
  Object literal may only specify known properties, and 'searchRepo' does not exist in type 'FileUploadConfig'.

66   searchRepo: 'test-search-repo',
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Looks like tests weren't touched for a significant amount of time and new features were added without tests.

  1. We should fix current tests.
  2. Enable CI (workflow seems to be in place already)
  3. Only merge new stuff with tests in place
  4. Add tests for new features that were already added without tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant