Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why i tag with waves-effect class appears around img? #189

Open
hackuun opened this issue Jan 20, 2018 · 2 comments
Open

Why i tag with waves-effect class appears around img? #189

hackuun opened this issue Jan 20, 2018 · 2 comments

Comments

@hackuun
Copy link

hackuun commented Jan 20, 2018

If I use div then everything ok. But if I apply it to img then it broke my markup - i tag appears around img

@hackuun
Copy link
Author

hackuun commented Jan 20, 2018

Ok, I found this - #121

Then another question - how then I style img if i is not allowing me to do that? I mean, I want to make it 100% width but I can't, because i tag appears.

@fians
Copy link
Owner

fians commented Feb 5, 2018

Hi @iamdubx, the reason why I put wrapper tag (in this case <i> on the image because the ripple effect need a container in order to work properly. Without wrapper tag, the ripple will broken.

This is how it looks like when the Waves attached in the <img> tag.

<i class="waves-effect">
   <div  class="waves-ripple waves-rippling"></div>
  <img src="#" />
</i>

Can you show me an example in jsfiddle of your problem? I suspect you have styling on your <i> tag that make your image styling is broken. But I will consider to change <i> with <div> for the wrapper if it necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants