-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support wasi-keyvalue #2447
Comments
@endocrimes Can you expand on the difference you identified around the (The main difference I did run into was around |
Past me forgot to link to a revision, but that got added since I last looked 😅 - now there's no meaningful difference 🎉 |
@itowlson - We talked about this in today's Spin Up meeting. There is a release going out early next week. If there is an opporutnity to get this in, it's possible. If not, we can move it to post release in the board. |
@mikkelhegn There is a PR out. The first step towards a release would be to get feedback on that, specifically on the critical question of how to manage the Spin world versioning. I'll ping the reviewers. |
Notably, this is basically the entire focus of WASI 0.2.1 and afaik we still haven't even completely figured out versioning for that upstream. |
@mikkelhegn given ^^ I think it is fair to say this will not be part of 2.6 |
Hey folks 👋, I'm happy to volunteer to implement the rest of the WASI key/value interface (atomics and batching) to help provide the basis for a second provider implementation for the interfaces, which will enable it to graduate to phase 3. Would the project be interested in the contribution? |
@devigned The project would be absolutely delighted - thank you! I've just rebased #2486 onto latest main - I don't know whether it's more convenient for you to PR onto that or to take a new branch from it and create a new PR - whatever suits you. As you're aware, #2486 only covers the Thanks again! |
My plan is to make a new branch from yours and create a new PR. I don't want to muddy your existing work while I fiddle.
Yes. I talked with @kate-goldenring about each of the impls. I believe I should be able to implement the rest of the interface over the data stores. The SQLite store may need a schema change, but I don't think it should be too bad. It'll be a great opportunity to test that the k/v interface will work well with multiple data stores. I really appreciate your support and will likely take you up on the offer to collaborate. |
wasi-keyvalue is relatively complete as an interface and the core interface (https://github.com/WebAssembly/wasi-keyvalue/blob/main/wit/store.wit) is almost identical to spin-kv (https://github.com/fermyon/spin/blob/main/wit/key-value.wit) with the primary difference being the
exists
function.We should add support for wasi-keyvalue to get broader ecosystem compatibility - and the ability to benefit from the extended interfaces over time.
The text was updated successfully, but these errors were encountered: