Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing Playsound command/module #9

Open
yuuwe-n opened this issue Feb 23, 2021 · 0 comments
Open

Implementing Playsound command/module #9

yuuwe-n opened this issue Feb 23, 2021 · 0 comments

Comments

@yuuwe-n
Copy link

yuuwe-n commented Feb 23, 2021

Sorry, if the code is incomplete with placeholders, I created a fork to implement the command Playsound to see if the format was correct. I need to integrate the feather sounds with this module. This is my first time with contributing with open source, or any code base so I am very sorry if I done things wrong.

Also with my pull request, I am pretty sure all these Options could be replaced, but I don't know how to.

Done so far

  • Pretty much sourced command from gamepedia to create struct and impl
  • Added placeholders for Source

To Do

  • integrate position with sound placement
  • integrate volume (placeholded with f32 values)
  • integrate pitch (placeholded with f32 values)
  • integrate min_volume (placeholded with f32 values)
  • integrate with actually playing sound
  • acquire lists of sounds and music (i think we have to make our own sounds and music)
This was referenced Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant