Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dangerfile doesn't work #32

Open
kleiberjp opened this issue May 16, 2020 · 2 comments
Open

Dangerfile doesn't work #32

kleiberjp opened this issue May 16, 2020 · 2 comments

Comments

@kleiberjp
Copy link

HI, I'm trying to implement danger on our CI ecosystem but at the moment of execute danger with xciv it fails with this error

[!] The exception involves the following plugins:

  • danger-xcov
    bundler: failed to load command: danger (/Users/vagrant/git/vendor/bundle/ruby/2.6.0/bin/danger)
    Danger::DSLError:
    [!] Invalid Dangerfile file: xcodebuild -list timed-out after 30 seconds. You might need to recreate the user schemes. You can override the timeout value with the environment variable FASTLANE_XCODE_LIST_TIMEOUT
    from Dangerfile:3

-> xcov.report(
scheme: Grability,

@mkaminow
Copy link

mkaminow commented Dec 2, 2020

I'm having almost the same issue:

`[18:37:00]: ▸ Coverage report successfully created at path: /Users/distiller/output/xcov_report/tmp/report.json20201201-3514-1hxp25n
+---------------------------------+--------+
| xcov Coverage Report |
+---------------------------------+--------+
| MyNetworking.framework | 57.49% |
| MyTvOSNetworkingKit.framework | 95.39% |
| KeychainAccess.framework | 25.26% |
+---------------------------------+--------+

[18:37:01]: Actual Code Coverage (59.38%) below threshold of 90.00%
[18:37:01]: The build has been marked as failed because minimum overall coverage has not been reached.
[!] The exception involves the following plugins:

  • danger-xcov

bundler: failed to load command: danger (/Users/distiller/output/vendor/bundle/ruby/2.7.0/bin/danger)
Danger::DSLError:
[!] Invalid Dangerfile file: Error creating your coverage report - see the log above
`

@DanielCreagh
Copy link

I think this is because your test coverage percentage is below the threshold. It's not a great fail message but I think that's all that causes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants