Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing refund and punish confirmations in state report #927

Open
h4sh3d opened this issue Jan 11, 2023 · 1 comment · May be fixed by #932
Open

Missing refund and punish confirmations in state report #927

h4sh3d opened this issue Jan 11, 2023 · 1 comment · May be fixed by #932
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@h4sh3d
Copy link
Member

h4sh3d commented Jan 11, 2023

We currently include the number of confirmations for cancel but not refund and punish, Alice and Bob will wait for their finality threshold to consider one or the other transaction mentioned final. To display that information on clients (e.g. GUI) we should include these two confirmation counters.
@h4sh3d h4sh3d added enhancement New feature or request good first issue Good for newcomers labels Jan 11, 2023
@h4sh3d
Copy link
Member Author

h4sh3d commented Jan 11, 2023

Same for the buy transaction, needs the number of confirmations

@TheCharlatan TheCharlatan linked a pull request Jan 13, 2023 that will close this issue
Swapd: Include buy, refund, and punish confs in state report #932
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Swapd: Include buy, refund, and punish confs in state report TheCharlatan/farcaster-node
1 participant
@h4sh3d