Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bob should rebroadcast lock tx if failed due to too-long-mempool-chain #921

Closed
Lederstrumpf opened this issue Jan 5, 2023 · 0 comments · Fixed by #935
Closed

Bob should rebroadcast lock tx if failed due to too-long-mempool-chain #921

Lederstrumpf opened this issue Jan 5, 2023 · 0 comments · Fixed by #935
Labels
bug Something isn't working

Comments

@Lederstrumpf
Copy link
Member

If Bob's lock tx failed due to too long mempool chains, he cannot currently abort the swap.
Moving forward with #777 would treat the collateral symptom that Bob can't abort after this failure, but the actual fix is that Bob should rebroadcast his lock tx on a subsequent block height increment if it failed initially, at least for too-long-mempool-chain (but I'd do this irrespective of the cause).

too-long-mempool-chain:

[2023-01-03T18:16:07Z INFO  farcaster_node::service] c7406439-1013-4ad1-acff-1e6ea1ef11f1 as Bob Maker | Received TakerCommit for swap - requesting walletd to create swap keys.
[2023-01-03T18:16:07Z INFO  farcaster_node::event] c7406439-1013-4ad1-acff-1e6ea1ef11f1 as Bob Maker | Trade state transition Make Deal -> Taker Commit
[2023-01-03T18:16:07Z INFO  farcaster_node::service] c7406439-1013-4ad1-acff-1e6ea1ef11f1 as Bob Maker | Creating new swap.
[2023-01-03T18:16:07Z INFO  farcaster_node::event] c7406439-1013-4ad1-acff-1e6ea1ef11f1 as Bob Maker | Trade state transition Taker Commit -> Swapd Launched
[2023-01-03T18:16:07Z INFO  farcaster_node::swapd::runtime] Starting swap: c7406439-1013-4ad1-acff-1e6ea1ef11f1
[2023-01-03T18:16:08Z INFO  farcaster_node::farcasterd::runtime] Service swap<c7406439-1013-4ad1-acff-1e6ea1ef11f1> is now connected
[2023-01-03T18:16:08Z INFO  farcaster_node::event] c7406439-1013-4ad1-acff-1e6ea1ef11f1 as Bob Maker | Trade state transition Swapd Launched -> Swapd Running
[2023-01-03T18:16:08Z INFO  farcaster_node::service] c7406439-1013-4ad1-acff-1e6ea1ef11f1 as Bob Maker | Creating Bob's Swap Key Manager
[2023-01-03T18:16:08Z INFO  farcaster_node::service] c7406439-1013-4ad1-acff-1e6ea1ef11f1 as Bob Maker | Accepting swap as Maker from Taker through peerd peerd<14840736420842179806503299422078541540 03c5cf4b3e5924756b6f3d2ab653755416812373b4fa542a05ab5dc8d039aa5eb5@0.0.0.0:7067>
[2023-01-03T18:16:08Z INFO  farcaster_node::service] c7406439-1013-4ad1-acff-1e6ea1ef11f1 as Bob Maker | Swap State Machine state transition Start Bob Maker -> Bob Init Maker
[2023-01-03T18:16:08Z INFO  farcaster_node::peerd::runtime] c7406439-1013-4ad1-acff-1e6ea1ef11f1 | Sent the Bob maker commit protocol message
[2023-01-03T18:16:08Z INFO  farcaster_node::service] c7406439-1013-4ad1-acff-1e6ea1ef11f1 as Bob Maker | Handling reveal with swap_key_manager
[2023-01-03T18:16:08Z INFO  farcaster_node::service] c7406439-1013-4ad1-acff-1e6ea1ef11f1 as Bob Maker | DLEQ proof from Alice successfully verified.
[2023-01-03T18:16:08Z INFO  farcaster_node::service] c7406439-1013-4ad1-acff-1e6ea1ef11f1 as Bob Maker | Swap State Machine state transition Bob Init Maker -> Bob Reveal
[2023-01-03T18:16:08Z INFO  farcaster_node::peerd::runtime] c7406439-1013-4ad1-acff-1e6ea1ef11f1 | Sent the reveal Bob protocol message
[2023-01-03T18:16:08Z INFO  farcaster_node::service] c7406439-1013-4ad1-acff-1e6ea1ef11f1 as Bob Maker | Fee: 1001 sat/kvB
[2023-01-03T18:16:08Z INFO  farcaster_node::service] c7406439-1013-4ad1-acff-1e6ea1ef11f1 as Bob Maker | Send 0.00001123 BTC to tb1qwlw9sj4p8wn6epz78c3efa62ylvzatj372h9up, this includes 0.00000123 BTC for the Lock transaction network fees
[2023-01-03T18:16:08Z INFO  farcaster_node::service] c7406439-1013-4ad1-acff-1e6ea1ef11f1 as Bob Maker | Watching Funding on address tb1qwlw9sj4p8wn6epz78c3efa62ylvzatj372h9up
[2023-01-03T18:16:08Z INFO  farcaster_node::service] c7406439-1013-4ad1-acff-1e6ea1ef11f1 as Bob Maker | Swap State Machine state transition Bob Reveal -> Bob Fee Estimated
[2023-01-03T18:16:08Z INFO  farcaster_node::service] c7406439-1013-4ad1-acff-1e6ea1ef11f1 as Bob Maker | Attempting to auto-fund Bitcoin
[2023-01-03T18:16:09Z INFO  farcaster_node::service] c7406439-1013-4ad1-acff-1e6ea1ef11f1 as Bob Maker | Auto-funded Bitcoin with txid: 9ad233946eaef8d5f4d85ae2272676e11f090390c8de8ce888deecdae04ac2b6
[2023-01-03T18:16:33Z WARN  farcaster_node::service] c7406439-1013-4ad1-acff-1e6ea1ef11f1 as Bob Maker | Error broadcasting Arbitrating Lock transaction: failed to broadcast tx: Electrum server error: "sendrawtransaction RPC error: {\"code\":-26,\"message\":\"too-long-mempool-chain, too many descendants for tx 585a13491e056e7d026cb9bc2adad238ee768942956f4d9fb2fa21affc30455a [limit: 25]\"}"
[2023-01-03T18:16:57Z INFO  farcaster_node::service] c7406439-1013-4ad1-acff-1e6ea1ef11f1 as Bob Maker | Tx Buy not on the mempool
[2023-01-03T18:16:57Z INFO  farcaster_node::service] c7406439-1013-4ad1-acff-1e6ea1ef11f1 as Bob Maker | Tx Arbitrating Lock not on the mempool
[2023-01-03T18:17:08Z INFO  farcaster_node::service] c7406439-1013-4ad1-acff-1e6ea1ef11f1 as Bob Maker | Tx Cancel not on the mempool
[2023-01-03T18:17:08Z INFO  farcaster_node::service] c7406439-1013-4ad1-acff-1e6ea1ef11f1 as Bob Maker | Tx Refund not on the mempool
[2023-01-05T05:14:31Z WARN  farcaster_node::service] c7406439-1013-4ad1-acff-1e6ea1ef11f1 as Bob Maker | Swap is already locked-in, cannot manually abort anymore.
[2023-01-05T05:16:54Z WARN  farcaster_node::service] c7406439-1013-4ad1-acff-1e6ea1ef11f1 as Bob Maker | Swap is already locked-in, cannot manually abort anymore.
[2023-01-05T05:32:03Z WARN  farcaster_node::service] c7406439-1013-4ad1-acff-1e6ea1ef11f1 as Bob Maker | Swap is already locked-in, cannot manually abort anymore.

bad-txns-inputs-missingorspent (I don't understand why this one failed yet since the funding utxo for address tb1qt3k99m60tnvuckre8yu2ag0q4fh2ulfklncl5l is still in the chain - maybe some intermittent reorg? In any case, should work if rebroadcast):

[2023-01-05T02:09:19Z INFO  farcaster_node::service] 96685b35-81db-496f-9f3c-f4a24691f07b as Bob Maker | Swap State Machine state transition Bob Init Maker -> Bob Reveal
[2023-01-05T02:09:19Z INFO  farcaster_node::peerd::runtime] 96685b35-81db-496f-9f3c-f4a24691f07b | Sent the reveal Bob protocol message
[2023-01-05T02:09:19Z INFO  farcaster_node::service] 96685b35-81db-496f-9f3c-f4a24691f07b as Bob Maker | Fee: 1001 sat/kvB
[2023-01-05T02:09:19Z INFO  farcaster_node::service] 96685b35-81db-496f-9f3c-f4a24691f07b as Bob Maker | Send 0.00001123 BTC to tb1qt3k99m60tnvuckre8yu2ag0q4fh2ulfklncl5l, this includes 0.00000123 BTC for the Lock transaction network fees
[2023-01-05T02:09:19Z INFO  farcaster_node::service] 96685b35-81db-496f-9f3c-f4a24691f07b as Bob Maker | Watching Funding on address tb1qt3k99m60tnvuckre8yu2ag0q4fh2ulfklncl5l
[2023-01-05T02:09:19Z INFO  farcaster_node::service] 96685b35-81db-496f-9f3c-f4a24691f07b as Bob Maker | Swap State Machine state transition Bob Reveal -> Bob Fee Estimated
[2023-01-05T02:09:19Z INFO  farcaster_node::service] 96685b35-81db-496f-9f3c-f4a24691f07b as Bob Maker | Attempting to auto-fund Bitcoin
[2023-01-05T02:09:20Z INFO  farcaster_node::service] 96685b35-81db-496f-9f3c-f4a24691f07b as Bob Maker | Auto-funded Bitcoin with txid: bc4de8ce782cd95df1f2552d209ab374b7707feaf85a45804b6710d9fef22a55
[2023-01-05T02:09:26Z INFO  farcaster_node::service] 96685b35-81db-496f-9f3c-f4a24691f07b as Bob Maker | Received AddressTransaction, processing tx bc4de8ce782cd95df1f2552d209ab374b7707feaf85a45804b6710d9fef22a55
[2023-01-05T02:09:26Z INFO  farcaster_node::service] 96685b35-81db-496f-9f3c-f4a24691f07b as Bob Maker | Your Bitcoin funding completed
[2023-01-05T02:09:26Z INFO  farcaster_node::service] 96685b35-81db-496f-9f3c-f4a24691f07b as Bob Maker | Watching Arbitrating Lock transaction (5dfe59a7ab4d8fc241a9424b8f26bcebcdccd8c7c5e11fa3010d5bb805f1f9fa)
[2023-01-05T02:09:26Z INFO  farcaster_node::service] 96685b35-81db-496f-9f3c-f4a24691f07b as Bob Maker | Watching Cancel transaction (4f0221ec079ee82f6f4a5a5daad75a2d8bc8b23eb9b1746579611b8497bb23aa)
[2023-01-05T02:09:26Z INFO  farcaster_node::service] 96685b35-81db-496f-9f3c-f4a24691f07b as Bob Maker | Watching Refund transaction (29cb5fb97226473cf75e104e57f97d24984880fabfaf6271fecf92707fda8674)
[2023-01-05T02:09:26Z INFO  farcaster_node::service] 96685b35-81db-496f-9f3c-f4a24691f07b as Bob Maker | Swap State Machine state transition Bob Fee Estimated -> Bob Funded
[2023-01-05T02:09:26Z INFO  farcaster_node::peerd::runtime] 96685b35-81db-496f-9f3c-f4a24691f07b | Sent the core arbitrating setup protocol message
[2023-01-05T02:09:26Z INFO  farcaster_node::service] 96685b35-81db-496f-9f3c-f4a24691f07b as Bob Maker | Cancel transaction created
[2023-01-05T02:09:26Z INFO  farcaster_node::service] 96685b35-81db-496f-9f3c-f4a24691f07b as Bob Maker | Refund transaction created
[2023-01-05T02:09:26Z INFO  farcaster_node::service] 96685b35-81db-496f-9f3c-f4a24691f07b as Bob Maker | Arbitrating Lock transaction created
[2023-01-05T02:09:26Z INFO  farcaster_node::service] 96685b35-81db-496f-9f3c-f4a24691f07b as Bob Maker | Watching Accordant Lock on address 53ZK9jRBYvvDqcfwvZq1aUhaFsY68Nf4vSNLh6JeLjDdaD19unaBMQULT2i4nr1UmhS6DFpn92AWQBdyMTk3ryAzBiNgwWV from height 1260190 - current height 1260191
[2023-01-05T02:09:26Z INFO  farcaster_node::service] 96685b35-81db-496f-9f3c-f4a24691f07b as Bob Maker | Watching Buy transaction (60b53fe36a18cc00658fc696688cece45968c8502e5a5985fe7bb5c24c20884f)
[2023-01-05T02:09:26Z INFO  farcaster_node::service] 96685b35-81db-496f-9f3c-f4a24691f07b as Bob Maker | Broadcasting Arbitrating Lock tx(5dfe59a7ab4d8fc241a9424b8f26bcebcdccd8c7c5e11fa3010d5bb805f1f9fa)
[2023-01-05T02:09:26Z INFO  farcaster_node::service] 96685b35-81db-496f-9f3c-f4a24691f07b as Bob Maker | Swap State Machine state transition Bob Funded -> Bob Refund Procedure Signatures
[2023-01-05T02:09:27Z WARN  farcaster_node::service] 96685b35-81db-496f-9f3c-f4a24691f07b as Bob Maker | Error broadcasting Arbitrating Lock transaction: failed to broadcast tx: Electrum server error: "sendrawtransaction RPC error: {\"code\":-25,\"message\":\"bad-txns-inputs-missingorspent\"}"
[2023-01-05T02:09:46Z INFO  farcaster_node::service] 96685b35-81db-496f-9f3c-f4a24691f07b as Bob Maker | Tx Refund not on the mempool
[2023-01-05T02:09:46Z INFO  farcaster_node::service] 96685b35-81db-496f-9f3c-f4a24691f07b as Bob Maker | Tx Arbitrating Lock not on the mempool
[2023-01-05T02:09:46Z INFO  farcaster_node::service] 96685b35-81db-496f-9f3c-f4a24691f07b as Bob Maker | Tx Buy not on the mempool
[2023-01-05T02:09:49Z INFO  farcaster_node::service] 96685b35-81db-496f-9f3c-f4a24691f07b as Bob Maker | Tx Cancel not on the mempool
[2023-01-05T05:14:32Z WARN  farcaster_node::service] 96685b35-81db-496f-9f3c-f4a24691f07b as Bob Maker | Swap is already locked-in, cannot manually abort anymore.
[2023-01-05T05:16:56Z WARN  farcaster_node::service] 96685b35-81db-496f-9f3c-f4a24691f07b as Bob Maker | Swap is already locked-in, cannot manually abort anymore.
[2023-01-05T05:32:05Z WARN  farcaster_node::service] 96685b35-81db-496f-9f3c-f4a24691f07b as Bob Maker | Swap is already locked-in, cannot manually abort anymore.
@Lederstrumpf Lederstrumpf added the bug Something isn't working label Jan 5, 2023
@TheCharlatan TheCharlatan linked a pull request Jan 13, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant