From d0690394532d3887538df7e5b938a4f34d24ae4e Mon Sep 17 00:00:00 2001 From: Federico Di Pierro Date: Tue, 26 Sep 2023 15:42:35 +0200 Subject: [PATCH 1/2] fix(pkg/build): fixed flaky test. Signed-off-by: Federico Di Pierro --- pkg/build/build_test.go | 60 ++++++++++++++++++++--------------------- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/pkg/build/build_test.go b/pkg/build/build_test.go index 1bbd64e..c8307a1 100644 --- a/pkg/build/build_test.go +++ b/pkg/build/build_test.go @@ -40,7 +40,7 @@ func TestBuild(t *testing.T) { RepoRoot: "./test", Target: root.Target{ Distro: "centos", - KernelRelease: "5.14.0-361.el9.x86_64", + KernelRelease: "5.14.0-362.el9.x86_64", KernelVersion: "1", }, }, @@ -49,15 +49,15 @@ func TestBuild(t *testing.T) { IgnoreErrors: false, }, expectedLocalObjects: []string{ - "falco_centos_5.14.0-361.el9.x86_64_1.ko", - "falco_centos_5.14.0-361.el9.x86_64_1.o", + "falco_centos_5.14.0-362.el9.x86_64_1.ko", + "falco_centos_5.14.0-362.el9.x86_64_1.o", }, expectedBucketObjects: []string{ - "falco_centos_5.14.0-361.el9.x86_64_1.ko", - "falco_centos_5.14.0-361.el9.x86_64_1.o", + "falco_centos_5.14.0-362.el9.x86_64_1.ko", + "falco_centos_5.14.0-362.el9.x86_64_1.o", }, shouldCreate: true, - name: "build 5.0.1+driver centos 5.14.0-361.el9.x86_64", + name: "build 5.0.1+driver centos 5.14.0-362.el9.x86_64", }, { opts: Options{ @@ -68,7 +68,7 @@ func TestBuild(t *testing.T) { RepoRoot: "./test", Target: root.Target{ Distro: "centos", - KernelRelease: "5.14.0-354.el9.x86_64", + KernelRelease: "5.14.0-364.el9.x86_64", KernelVersion: "1", }, }, @@ -77,17 +77,17 @@ func TestBuild(t *testing.T) { IgnoreErrors: false, }, expectedLocalObjects: []string{ - "falco_centos_5.14.0-354.el9.x86_64_1.ko", - "falco_centos_5.14.0-354.el9.x86_64_1.o", - "falco_centos_5.14.0-361.el9.x86_64_1.ko", - "falco_centos_5.14.0-361.el9.x86_64_1.o", + "falco_centos_5.14.0-364.el9.x86_64_1.ko", + "falco_centos_5.14.0-364.el9.x86_64_1.o", + "falco_centos_5.14.0-362.el9.x86_64_1.ko", + "falco_centos_5.14.0-362.el9.x86_64_1.o", }, expectedBucketObjects: []string{ - "falco_centos_5.14.0-361.el9.x86_64_1.ko", - "falco_centos_5.14.0-361.el9.x86_64_1.o", + "falco_centos_5.14.0-362.el9.x86_64_1.ko", + "falco_centos_5.14.0-362.el9.x86_64_1.o", }, shouldCreate: false, // since it is not publishing - name: "build 5.0.1+driver centos 5.14.0-354.el9.x86_64", + name: "build 5.0.1+driver centos 5.14.0-364.el9.x86_64", }, { opts: Options{ @@ -98,7 +98,7 @@ func TestBuild(t *testing.T) { RepoRoot: "./test", Target: root.Target{ Distro: "centos", - KernelRelease: "5.14.0-361.el9.x86_64", // try to rebuild same object. + KernelRelease: "5.14.0-362.el9.x86_64", // try to rebuild same object. KernelVersion: "1", }, }, @@ -107,17 +107,17 @@ func TestBuild(t *testing.T) { IgnoreErrors: false, }, expectedLocalObjects: []string{ - "falco_centos_5.14.0-354.el9.x86_64_1.ko", - "falco_centos_5.14.0-354.el9.x86_64_1.o", - "falco_centos_5.14.0-361.el9.x86_64_1.ko", - "falco_centos_5.14.0-361.el9.x86_64_1.o", + "falco_centos_5.14.0-364.el9.x86_64_1.ko", + "falco_centos_5.14.0-364.el9.x86_64_1.o", + "falco_centos_5.14.0-362.el9.x86_64_1.ko", + "falco_centos_5.14.0-362.el9.x86_64_1.o", }, expectedBucketObjects: []string{ - "falco_centos_5.14.0-361.el9.x86_64_1.ko", - "falco_centos_5.14.0-361.el9.x86_64_1.o", + "falco_centos_5.14.0-362.el9.x86_64_1.ko", + "falco_centos_5.14.0-362.el9.x86_64_1.o", }, shouldCreate: false, // since objects are already present, nothing should be created - name: "rebuild 5.0.1+driver centos 5.14.0-361.el9.x86_64", + name: "rebuild 5.0.1+driver centos 5.14.0-362.el9.x86_64", }, { opts: Options{ @@ -128,7 +128,7 @@ func TestBuild(t *testing.T) { RepoRoot: "./test", Target: root.Target{ Distro: "centos", - KernelRelease: "5.14.0-361.el9.x86_64", // try to rebuild same object. + KernelRelease: "5.14.0-362.el9.x86_64", // try to rebuild same object. KernelVersion: "1", }, }, @@ -137,17 +137,17 @@ func TestBuild(t *testing.T) { IgnoreErrors: false, }, expectedLocalObjects: []string{ - "falco_centos_5.14.0-354.el9.x86_64_1.ko", - "falco_centos_5.14.0-354.el9.x86_64_1.o", - "falco_centos_5.14.0-361.el9.x86_64_1.ko", - "falco_centos_5.14.0-361.el9.x86_64_1.o", + "falco_centos_5.14.0-364.el9.x86_64_1.ko", + "falco_centos_5.14.0-364.el9.x86_64_1.o", + "falco_centos_5.14.0-362.el9.x86_64_1.ko", + "falco_centos_5.14.0-362.el9.x86_64_1.o", }, expectedBucketObjects: []string{ - "falco_centos_5.14.0-361.el9.x86_64_1.ko", - "falco_centos_5.14.0-361.el9.x86_64_1.o", + "falco_centos_5.14.0-362.el9.x86_64_1.ko", + "falco_centos_5.14.0-362.el9.x86_64_1.o", }, shouldCreate: true, // since objects are already present, nothing should be created - name: "rebuild 5.0.1+driver centos 5.14.0-361.el9.x86_64", + name: "rebuild 5.0.1+driver centos 5.14.0-362.el9.x86_64", }, } From e895cef950e2654db291053b63ba1443e1af512a Mon Sep 17 00:00:00 2001 From: Federico Di Pierro Date: Tue, 26 Sep 2023 15:44:44 +0200 Subject: [PATCH 2/2] chore: added pull request github template. Signed-off-by: Federico Di Pierro --- .github/PULL_REQUEST_TEMPLATE.md | 70 ++++++++++++++++++++++++++++++++ 1 file changed, 70 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 0000000..47811f6 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,70 @@ + + +**What type of PR is this?** + +> Uncomment one (or more) `/kind <>` lines: + +> /kind bug + +> /kind cleanup + +> /kind design + +> /kind documentation + +> /kind failing-test + +> /kind feature + + + +**Any specific area of the project related to this PR?** + +> Uncomment one (or more) `/area <>` lines: + +> /area build + +> /area cmd + +> /area pkg + +> /area docs + +> /area tests + + +**What this PR does / why we need it**: + +**Which issue(s) this PR fixes**: + + + +Fixes # + +**Special notes for your reviewer**: + +**Does this PR introduce a user-facing change?**: + + + +```release-note + +```