Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and upgrade Github Workflows files #324

Open
IgorShadurin opened this issue May 3, 2023 · 1 comment
Open

Review and upgrade Github Workflows files #324

IgorShadurin opened this issue May 3, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@IgorShadurin
Copy link
Collaborator

.github/workflows/docker.yml - This file contains build commands for docker without pushing to the docker hub. The build works when creating ANY PR (it is not correct, it should be triggered only for development and master). Some parameters have typos ("NEXT_PUBLIC_BLOCKCHAIN_INFO=blockchanin"). It looks like the docker build is not needed and is not used. We also have a docker hub that hasn't had any project updates for 5 months: https://hub.docker.com/r/fairdatasociety/fairdrive. Do you think we need this action? @darkobas2

.github/workflows/swarm.yml and .github/workflows/node.js.yml - these 2 actions run simultaneously. node.js.yml doesn't make sense at the moment, as it only builds the project and nothing else happens to the build.
swarm.yml builds the project and uploads it to swarm. It is worth transforming node.js.yml so that it runs tests and checks the correctness of the code with a linter. And only after successfully passing the tests and the linter, swarm.yml should be launched.
Sequential launch of actions can be done using the workflow_run event.

@IgorShadurin IgorShadurin added the enhancement New feature or request label May 3, 2023
@darkobas2
Copy link
Collaborator

It was added because there were a lot of pushes which ended up not beeing able to build in a clean env either because of production flags or module caching. So idea is that this is a general check if the code builds from scratch, with production flags and without cached modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants