Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Habitat_env_factory enforce_scenes_greater_eq_environments not working as expected. #1979

Open
lasuomela opened this issue Jun 11, 2024 · 0 comments

Comments

@lasuomela
Copy link

Habitat-Lab and Habitat-Sim versions

Habitat-Lab: master

Habitat-Sim: master

🐛 Bug

In habitat_env_factory, the functionality provided by enforce_scenes_greater_eq_environments is not working as expected. In cases where the number of environments is greater than number of scenes, habitat_env_factory should return len(scenes) environments with 1 scene per environment. At the moment, the actual return value is len(scenes) environments with len(scenes) +1 scenes per environment. This is caused by incorrect indentation of lines 63-65 in habitat_env_factory. Correct indentation level would be the same as lines 59-62.

Steps to Reproduce

I don't have a self-contained MWE, but on my own codebase I've confirmed changing the indentation fixes the error.

Expected behavior

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant