Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numeric-Input Decimal Issue #14045

Closed
btf93 opened this issue Oct 31, 2018 · 7 comments
Closed

Numeric-Input Decimal Issue #14045

btf93 opened this issue Oct 31, 2018 · 7 comments

Comments

@btf93
Copy link

btf93 commented Oct 31, 2018

I've impemented the React numeric-input into my code, however I've noticed that when entering a figure such as '0.05', it doesn't allow it. '0.15' for example works fine, but the '0.0' is the issue.

It can be replicated at this link: http://vlad-ignatov.github.io/react-numeric-input/

In particular with the 'With inline styles disabled' format. I raised this elsewhere but was told to come here to raise it too. Thanks.

@Xizario
Copy link

Xizario commented Oct 31, 2018

@btf93 see this vlad-ignatov/react-numeric-input#86

@btf93
Copy link
Author

btf93 commented Oct 31, 2018

@btf93 see this vlad-ignatov/react-numeric-input#86

How do I access the fix? Is it in the latest version? Sorry, I'm quite new to React! Thanks.

I looked through the release documentation but couldn't see when it was released?

@sagar-gavhane
Copy link

Hi @btf93,

Can you provide sample code base with screenshot for further reference?

@btf93
Copy link
Author

btf93 commented Oct 31, 2018

Hi, if the issue has been fixed I’ll try upgrading to React 16.0.0 tomorrow. We’re currently using 15.4.2 I think (from memory as I’m not at work now), so we’re quite far behind. I’ll report back tomorrow once I’ve tried it and if it doesn’t work I’ll supply some sample code. Thanks!

@btf93
Copy link
Author

btf93 commented Nov 13, 2018

I've upgraded to the latest version of React. Was this fixed applied in the last version or do I have to do something different entirely to get it to work?

@Xizario
Copy link

Xizario commented Nov 13, 2018

@btf93 it is not an issue with React, it is problem in the 'react-numeric-input' component that you are using. This is third party package and not part of the React. This is why I suggest you to write in the repository already linked in my previous post. They have it on pull-request, but seems the author of the package is not maintaining it, and their last release is from nearly one year ago.

@btf93
Copy link
Author

btf93 commented Nov 13, 2018

@Xizario Oh I see! Sorry I'm really new to React, hence the confusion here. That makes perfect sense now and I've asked for an update in the link you sent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants