Build failed with error message "cachelib/navy/common/FdpNvme.h:143:28: error: expected ‘)’ before ‘&’ token 143 | explicit FdpNvme(NvmeData& data, struct nvme_fdp_ruh_status* ruh_status); | ~ ^ | ) make[2]: *** [navy/CMakeFiles/cachelib_navy.dir/build.make:328: navy/CMakeFiles/cachelib_navy.dir/common/Device.cpp.o] Error 1 make[1]: *** [CMakeFiles/Makefile2:395: navy/CMakeFiles/cachelib_navy.dir/all] Error 2 make: *** [Makefile:130: all] Error 2 build-package.sh: error: make failed"

[ByteMansion]

Describe the bug

Build failed with error output "cachelib/navy/common/FdpNvme.h:143:28: error: expected ‘)’ before ‘&’ token
  143 |   explicit FdpNvme(NvmeData& data, struct nvme_fdp_ruh_status* ruh_status);
      |                   ~        ^
      |                            )
make[2]: *** [navy/CMakeFiles/cachelib_navy.dir/build.make:328: navy/CMakeFiles/cachelib_navy.dir/common/Device.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:395: navy/CMakeFiles/cachelib_navy.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
build-package.sh: error: make failed"

To Reproduce
Steps to reproduce the behavior:

1. build.sh -j or build-package.sh -S -i cachelib

Expected behavior
Build succeeded.

Screenshots

Desktop (please complete the following information):

• OS: ubuntu 20.04 running in workstation as a guest os.

Additional context

root@ubuntu:/home/essd/CacheLib# cat /proc/cpuinfo 
processor	: 0
vendor_id	: GenuineIntel
cpu family	: 6
model		: 140
model name	: 11th Gen Intel(R) Core(TM) i5-1135G7 @ 2.40GHz
stepping	: 1
microcode	: 0xffffffff
cpu MHz		: 2419.198
cache size	: 8192 KB
physical id	: 0
siblings	: 1
core id		: 0
cpu cores	: 1
apicid		: 0
initial apicid	: 0
fpu		: yes
fpu_exception	: yes
cpuid level	: 27
wp		: yes
flags		: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss syscall nx pdpe1gb rdtscp lm constant_tsc arch_perfmon nopl xtopology tsc_reliable nonstop_tsc cpuid tsc_known_freq pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single ssbd ibrs ibpb stibp fsgsbase tsc_adjust bmi1 avx2 smep bmi2 invpcid avx512f avx512dq rdseed adx smap clflushopt clwb avx512cd sha_ni avx512bw avx512vl xsaveopt xsavec xsaves arat avx512_vpopcntdq md_clear flush_l1d arch_capabilities
bugs		: spectre_v1 spectre_v2 spec_store_bypass swapgs retbleed gds bhi
bogomips	: 4838.39
clflush size	: 64
cache_alignment	: 64
address sizes	: 43 bits physical, 48 bits virtual
power management:

[ByteMansion]

I also encountered this issue #323 if I didn't contain its fix.

[ByteMansion]

I guess that this problem only occurred in VM with a single-core CPU. I didn't encounter the same issue in a new machine with multiple cores.

[pbhandar2]

Is this issue still occurring? The recent fixes might have mitigated this. I will close this if it is not a problem anymore or if I don't hear back in a few days.

[ByteMansion]

Is this issue still occurring? The recent fixes might have mitigated this. I will close this if it is not a problem anymore or if I don't hear back in a few days.

I didn't encounter this issue after then because I didn't build this repo using only 1 core.