You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Complete refactor of options API based on generated struct and methods from a `options.json` file.
- Add struct and methods generation code in f3dOptions.cmake
- Add generation in library/CMakeLists.txt
- Add options.json containing all options
- Add new API in options.h and implement it in options.cxx, remove old API
- Adapt code in library and in app for the new API
- Add options testing
- Added a quick doc about the three APIs and in header docs
- Add a C++11 compatibility
- Added examples
- Improve clang-format CI and update files accordingly
Will be done in other PRs:
- Add deprecation logic in generation code: #1568
- Rework application and simplify option logic: #1569
- Add more options types : #1570
- Add actual parsing for all options types: #1571
- Add complete documentation for options and option parsing: #1572
- Proper java and javascript bindings: #1573#1574
- use exception translator in python bindings: #1575
- Improve compile-time opti in options_tools.h.in: #1576
Nokse22
pushed a commit
to Nokse22/f3d
that referenced
this issue
Sep 21, 2024
Complete refactor of options API based on generated struct and methods from a `options.json` file.
- Add struct and methods generation code in f3dOptions.cmake
- Add generation in library/CMakeLists.txt
- Add options.json containing all options
- Add new API in options.h and implement it in options.cxx, remove old API
- Adapt code in library and in app for the new API
- Add options testing
- Added a quick doc about the three APIs and in header docs
- Add a C++11 compatibility
- Added examples
- Improve clang-format CI and update files accordingly
Will be done in other PRs:
- Add deprecation logic in generation code: f3d-app#1568
- Rework application and simplify option logic: f3d-app#1569
- Add more options types : f3d-app#1570
- Add actual parsing for all options types: f3d-app#1571
- Add complete documentation for options and option parsing: f3d-app#1572
- Proper java and javascript bindings: f3d-app#1573f3d-app#1574
- use exception translator in python bindings: f3d-app#1575
- Improve compile-time opti in options_tools.h.in: f3d-app#1576
Is your feature request related to a problem? Please describe.
The python bindings rely on handling and forwarding exception manually, use exception translator instead:
https://pybind11.readthedocs.io/en/stable/advanced/exceptions.html#registering-custom-translators
The text was updated successfully, but these errors were encountered: