-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protein-translation: slightly confusing setup #1937
Comments
Looks like the exercise was added in this PR: #603. There's no discussion on this design descision. It seems to me that it gives students the freedom to prepare the input data for efficient lookup (e.g. hash map), which can then be performed many times. (even though the test suite doesn't do that) I'm sure the exercise could've been designed a different way, but is it worth it to break existing solutions? |
I don't think so. I just wanted to discuss some of the design decisions to maybe improve future exercises. I'll post a more detailed reply next week when I'm back at work! |
Okay, so what I found confusing/did not like was:
Summarizing, I think this exercise has its fair share of problems. I'm not suggesting we redesign the exercise, as that would indeed break existing solutions, but I am writing this as a sort of cautionary warning for when new exercises are being added. |
I agree. There are some situations where it might make sense to force a specific solution, if the intent of the exercise is to teach a specific concept. (I like the design of space-age for example.) On the other hand, that's what concept exercises of a syllabus are for... Either way, this exercise doesn't really teach anything, it just forces a specific, weird solution. What do you think about deprecating it? |
Indeed!
Let me ponder this a bit! |
We've talked this over internally, and we feel that it might be best to restructure the exercise. Yes it'll break existing solutions, but it'll make things a lot more sane for future students. |
Alright, I should be able to find some time in the evening. |
I'm not really sure why the
protein-translation
exercise has an additionalparse
function that returns apub struct CodonsInfo<'a>
. It feels a bit weird to me. Maybe a better approach would be to model the codons as an enum?The text was updated successfully, but these errors were encountered: