Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub CI: fail on veraPDF crash #18

Merged
merged 1 commit into from
May 7, 2024

Conversation

JanProvaznik
Copy link
Contributor

fixes #17

@@ -35,4 +35,4 @@ jobs:
- name: Get PDFs
uses: actions/download-artifact@v3
- name: Run VeraPDF
run: verify Thesis/*.pdf | tee /dev/stderr | grep -qE 'nonCompliant="0"'
run: verify Thesis/*.pdf | tee /dev/stderr | grep -qE 'nonCompliant="0" failedJobs="0"'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
thanks for noticing this :D I didn't really check if it fails properly.

Since the original problem is that the pipeline discards the exit status of verify and there's no point in looking at the grepped contents, shouldn't this work better?

Suggested change
run: verify Thesis/*.pdf | tee /dev/stderr | grep -qE 'nonCompliant="0" failedJobs="0"'
run: verify Thesis/*.pdf

This ofc assumes that the verify script exits properly, which I see is not the case...so this might require more fixing in https://github.com/mff-cuni-cz/cuni-thesis-validator/blob/master/verify#L3 as well:

-verapdf --profile /opt/uk-profile.xml $@
+exec verapdf --profile /opt/uk-profile.xml "$@"

if you see that viable can you please send a MR in that direction too? If not, lmk, we can just merge this so that the issue is solved and elaborate later. :)

Thanks!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(on the second thought, the immediate fix is OK, merging :D )

@exaexa exaexa merged commit 0ed4027 into exaexa:master May 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDF/A verification GH Action succeeds when verapdf crashes
2 participants