Add behavior to hide modules from trainings. #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thet
force-pushed
the
scrum-1573--hide-modules
branch
from
7e72bc7
to
c161a70
Compare
thet
force-pushed
the
scrum-1573--hide-modules
branch
2 times, most recently
from
79ef584
to
c9c2d73
Compare
Ref: scrum-1573
thet
force-pushed
the
scrum-1573--hide-modules
branch
from
c9c2d73
to
6938600
Compare
|
@reinhardt the test error is probably a test isolation error. locally the tests run through. |
|
Fixed! |
reinhardt
approved these changes
Nov 17, 2023
thet
commented
Nov 17, 2023
| @@ -78,6 +78,9 @@ def setUp(self): | |||
| fti_module.behaviors = tuple( | |||
| list(fti_module.behaviors) + ["euphorie.hide_from_training"] | |||
| ) | |||
| from plone.dexterity.schema import SCHEMA_CACHE | |||
|
|
|||
| SCHEMA_CACHE.invalidate("euphorie.module") | |||
There was a problem hiding this comment.
wow, thanks. didn't think of the schema cache!
There was a problem hiding this comment.
I wasn't even aware it existed - I did a quick step through and got lucky because I noticed it. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: scrum-1573
Merge together:
#669
https://github.com/syslabcom/daimler.oira/pull/248