Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiding "impossible" models when navigating between regions #56

Closed
bvreede opened this issue Apr 1, 2022 · 1 comment · Fixed by #60
Closed

Hiding "impossible" models when navigating between regions #56

bvreede opened this issue Apr 1, 2022 · 1 comment · Fixed by #60

Comments

@bvreede
Copy link
Member

bvreede commented Apr 1, 2022

Following the discussion in #51, it would be good to implement this. At the moment, a user can find "impossible" results by selecting a combination of model/season/etc, then moving to another region that this model does/should not show. When starting at this region, the model does not appear in the dropdown. However, when moving towards that region with the selection already made, the results show anyway. Sometimes the CPM image is missing. Sometimes it is not. In either of those situations, there should be a clear result showing that this model does not work for the selected region.

@geek-yang
Copy link
Member

Thanks for the suggestion. Will improve this by using the "watcher" feature of vue/nuxt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants