Skip to content
This repository has been archived by the owner on Aug 30, 2024. It is now read-only.

Facet clearing functionality relies on code outside of module #16

Open
fantapop opened this issue Aug 16, 2016 · 1 comment
Open

Facet clearing functionality relies on code outside of module #16

fantapop opened this issue Aug 16, 2016 · 1 comment

Comments

@fantapop
Copy link

the function removeFacet clears $scope.currentSearch and then calls $scope.initFacets which resyncs currentSearch from the url.

magic_search.js does not add the search to the url so when you clear try to clear an individual facet all facets are removed. The demo adds an additional javascript file main.js which is not included with the module that updates the url after each facet is added. The url update could should be handled inside the module.

@dkavanagh
Copy link
Member

I agree. I've also dealt with this and just put up with it till now. I'm opening another issue for a greater re-factor I've had in mind for a while now (since around ng-conf time).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants