Skip to content
This repository has been archived by the owner on Aug 30, 2024. It is now read-only.

Src files should use dash instead of underscore for naming convention #15

Open
ezy opened this issue Mar 9, 2016 · 3 comments
Open

Comments

@ezy
Copy link

ezy commented Mar 9, 2016

Currently there's a conflict with bower where the src files aren't being automatically picked up because of the naming convention. Changing _ to - will resolve this. eg. magic_search.js => magic-search.js

@ezy
Copy link
Author

ezy commented Mar 10, 2016

I attempted to fix this but got bogged down in the subbed 'dist' folder and issues with bower versioning and grunt release. I wasn't able to bower install my forked version because the dist folder doesn't update. In the end was taking up too much time. Here's my updated repo and files if anyone wants to resolve though. https://github.com/ezy/magic-search-dist. Or let me know if I've missed something :)

@dkavanagh
Copy link
Member

Thanks for this. I'll look into it and get it fixed. I've been trying to wrap up some work since I'm heading to NYC for a robotics competition tomorrow. Soonest I can work on this is Monday unless I find some time one evening.

@ezy
Copy link
Author

ezy commented Mar 10, 2016

Hey my pleasure - thanks for the awesome search functionality! I might get a bit of time to take another look at it again. Will keep my forked version updated if I do.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@ezy @dkavanagh and others