From 10b1a4d31065e51205092e1d90377b3ac82eb665 Mon Sep 17 00:00:00 2001 From: Attila Lendvai Date: Mon, 23 Sep 2024 10:29:10 +0200 Subject: [PATCH] chore: reduce log noise at default level (#4824) (#4825) --- pkg/api/transaction.go | 3 +-- pkg/postage/listener/listener.go | 2 +- pkg/topology/kademlia/kademlia.go | 6 ++---- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/pkg/api/transaction.go b/pkg/api/transaction.go index 6f93be7ca57..5be66c7fb42 100644 --- a/pkg/api/transaction.go +++ b/pkg/api/transaction.go @@ -144,8 +144,7 @@ func (s *Service) transactionResendHandler(w http.ResponseWriter, r *http.Reques err := s.transaction.ResendTransaction(r.Context(), paths.Hash) if err != nil { - logger.Debug("resend transaction failed", "tx_hash", paths.Hash, "error", err) - logger.Error(nil, "resend transaction failed", "tx_hash", paths.Hash) + logger.Error(nil, "resend transaction failed", "tx_hash", paths.Hash, "error", err) if errors.Is(err, transaction.ErrUnknownTransaction) { jsonhttp.NotFound(w, errUnknownTransaction) } else if errors.Is(err, transaction.ErrAlreadyImported) { diff --git a/pkg/postage/listener/listener.go b/pkg/postage/listener/listener.go index 39b6532d8fe..9750c09b7e3 100644 --- a/pkg/postage/listener/listener.go +++ b/pkg/postage/listener/listener.go @@ -329,7 +329,7 @@ func (l *listener) Listen(ctx context.Context, from uint64, updater postage.Even events, err := l.ev.FilterLogs(ctx, l.filterQuery(big.NewInt(int64(from)), big.NewInt(int64(to)))) if err != nil { l.metrics.BackendErrors.Inc() - l.logger.Warning("could not get logs", "error", err) + l.logger.Warning("could not get blockchain log", "error", err) lastConfirmedBlock = 0 continue } diff --git a/pkg/topology/kademlia/kademlia.go b/pkg/topology/kademlia/kademlia.go index 8269b0f4012..9462372093f 100644 --- a/pkg/topology/kademlia/kademlia.go +++ b/pkg/topology/kademlia/kademlia.go @@ -440,11 +440,9 @@ func (k *Kad) connectionAttemptsHandler(ctx context.Context, wg *sync.WaitGroup, return case errors.Is(err, p2p.ErrPeerBlocklisted): k.logger.Debug("peer still in blocklist", "peer_address", bzzAddr) - k.logger.Warning("peer still in blocklist") return case err != nil: k.logger.Debug("peer not reachable from kademlia", "peer_address", bzzAddr, "error", err) - k.logger.Warning("peer not reachable when attempting to connect") return } @@ -457,7 +455,7 @@ func (k *Kad) connectionAttemptsHandler(ctx context.Context, wg *sync.WaitGroup, k.recalcDepth() - k.logger.Info("connected to peer", "peer_address", peer.addr, "proximity_order", peer.po) + k.logger.Debug("connected to peer", "peer_address", peer.addr, "proximity_order", peer.po) k.notifyManageLoop() k.notifyPeerSig() } @@ -1218,7 +1216,7 @@ func (k *Kad) onConnected(ctx context.Context, addr swarm.Address) error { // Disconnected is called when peer disconnects. func (k *Kad) Disconnected(peer p2p.Peer) { - k.logger.Info("disconnected peer", "peer_address", peer.Address) + k.logger.Debug("disconnected peer", "peer_address", peer.Address) k.connectedPeers.Remove(peer.Address)