Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Clone derivation from Query #1482

Open
carver opened this issue Sep 24, 2024 · 0 comments
Open

Remove Clone derivation from Query #1482

carver opened this issue Sep 24, 2024 · 0 comments
Assignees
@carver
Labels
flamingo Maintenance or downtime for the person on Flamingo rotation to tackle

Comments

@carver
Copy link
Collaborator

carver commented Sep 24, 2024

Cloning Query seems like a bad idea. Especially FindContentQuery, with it's message sending/receiving logic. It's also not tiny, so would be a performance boon.

After FindContentQuery doesn't derive Clone anymore, we can remove the crossbeam dependency, and go back to a standard message channel.
@carver carver added the flamingo Maintenance or downtime for the person on Flamingo rotation to tackle label Sep 24, 2024
@carver carver self-assigned this Sep 24, 2024
@carver carver mentioned this issue Sep 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carver carver

Labels
flamingo Maintenance or downtime for the person on Flamingo rotation to tackle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@carver