Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No comments after export/import a pad #102

Closed
CompuRoot opened this issue Sep 16, 2016 · 10 comments
Closed

No comments after export/import a pad #102

CompuRoot opened this issue Sep 16, 2016 · 10 comments
Assignees
@JohnMcLear
Labels
bug

Comments

@CompuRoot
Copy link

CompuRoot commented Sep 16, 2016 •
edited
Loading

Exporting a pad and following import to another pad haven't exported comments, just keeps yellow highlighting (possibly related to issue#79)
@lpagliari
Copy link
Contributor

Yes, @CompuRoot , I believe #79 is related to this. We're currently working on a fix for that other issue, probably when it is finished it will be easier to fix this one.

@pescepalla pescepalla mentioned this issue Apr 2, 2020
Closed
@JohnMcLear
Copy link
Member

If you export/import now you get null as comment contents..

@JohnMcLear JohnMcLear added the bug label Oct 15, 2020
@JohnMcLear
Copy link
Member

JohnMcLear commented Nov 3, 2020 •
edited
Loading

Oh, export/import was never supported.. Heh..

Well Google Docs does this by having an "index" of comments which looks like this...

<body>
   <div class="c4">
      <p class="c5"><span>Testing for peace</span><sup><a href="#cmnt1" id="cmnt_ref1">[a]</a></sup></p>
      <p class="c0"><span class="c1"></span></p>
      <p class="c0"><span class="c1"></span></p>
      <div class="c2">
         <p class="c3"><a href="#cmnt_ref1" id="cmnt1">[a]</a><span class="c1">Why tho?</span></p>
      </div>
   </div>
</body>

note that the whole line has links at the end showing each comment from that line...

Do people really expect to export/import comments as HTML when they can just use the .etherpad format? At what point do we draw the line here on what is pushed out as HTML?

@JohnMcLear
Copy link
Member

Oh, actually exporting to .etherpad then importing exhibits this behavior so this is defo a bug that needs addressing.. 💯

@JohnMcLear JohnMcLear self-assigned this Nov 3, 2020
@JohnMcLear
Copy link
Member

Oh I see ep_comments is using comments:padId and not pad:padId:comments which is correct storage mechanism.

Ugh. I will probably need to extend ExportEtherpad.js have a plugin hook to define a context to grab or something, not ideal. I wonder why comments aren't under the padId namespace like everything else, must be a reason...

@JohnMcLear
Copy link
Member

Track at ether/etherpad-lite#4466

Ready for testing.

@JohnMcLear
Copy link
Member

Also track at #151 which now exports comments to HTML also.

@JohnMcLear
Copy link
Member

JohnMcLear commented Nov 8, 2020 •
edited
Loading

.etherpad done
.html re-import not done and is outside of scope.

@CompuRoot
Copy link
Author

.etherpad done
.html re-import not done and is outside of scope.

Thank you !

@JohnMcLear
Copy link
Member

Yw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JohnMcLear JohnMcLear

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JohnMcLear @CompuRoot @lpagliari