tests: remaining errors.Is conversions

[redwrasse]

tests directory errors.Is conversions, as part of #18576

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: redwrasse
Once this PR has been reviewed and has the lgtm label, please assign jmhbnz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @redwrasse. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 57.89474% with 8 lines in your changes missing coverage. Please review.

Project coverage is 68.82%. Comparing base (fd83aba) to head (12284ab).
Report is 12 commits behind head on main.

❗ Current head 12284ab differs from pull request most recent head 26d26d0

Please upload reports for the commit 26d26d0 to get more accurate results.

Files with missing lines	Patch %	Lines
server/storage/wal/wal.go	71.42%	2 Missing and 2 partials ⚠️
etcdctl/ctlv3/command/completion_command.go	0.00%	1 Missing ⚠️
etcdctl/ctlv3/command/ep_command.go	0.00%	1 Missing ⚠️
etcdutl/etcdutl/completion_commmand.go	0.00%	1 Missing ⚠️
server/storage/wal/file_pipeline.go	0.00%	0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Files with missing lines	Coverage Δ
server/storage/wal/repair.go	56.14% <100.00%> (ø)
etcdctl/ctlv3/command/completion_command.go	0.00% <0.00%> (ø)
etcdctl/ctlv3/command/ep_command.go	0.00% <0.00%> (ø)
etcdutl/etcdutl/completion_commmand.go	0.00% <0.00%> (ø)
server/storage/wal/file_pipeline.go	90.69% <0.00%> (ø)
server/storage/wal/wal.go	57.73% <71.42%> (+0.27%)	⬆️

... and 24 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18634      +/-   ##
==========================================
+ Coverage   68.81%   68.82%   +0.01%     
==========================================
  Files         420      420              
  Lines       35522    35535      +13     
==========================================
+ Hits        24443    24456      +13     
- Misses       9651     9653       +2     
+ Partials     1428     1426       -2     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd83aba...26d26d0. Read the comment docs.

[ivanvc]

Hi @redwrasse, thanks for opening this pull request. I know this is a draft, but I see the following instances that need to be updated:

• tests/integration/v3_grpc_test.go:1565: if err != nil && err != context.DeadlineExceeded {
• tests/integration/v3_lease_test.go:1089: if terr != nil && terr != gofail.ErrDisabled {
• tests/integration/clientv3/maintenance_test.go:307: if err != nil && err != context.Canceled {
• tests/integration/clientv3/watch_test.go:812: if err := cli.Close(); err != nil && err != context.Canceled {

[redwrasse]

Added those is @ivanvc . Let me know if you see anymore, otherwise I'll mark this ready for review.