Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Queue Worker can not (of course) set the status of a deleted AMI set #171

Open
DiegoPino opened this issue Jun 26, 2023 · 1 comment
Open

Queue Worker can not (of course) set the status of a deleted AMI set #171

DiegoPino opened this issue Jun 26, 2023 · 1 comment
Assignees
@DiegoPino
Labels
bug Something isn't working queue workers Ones taking the FI and doing the FO queue FIFO Release duty Things only a mad person should do Reporting Errors, Logs, etc.
Milestone
0.5.0

Comments

@DiegoPino
Copy link
Member

What?

Well. If you send to background processing and then delete the AMI set even if the queue item is as atomic as possible (means can be processed without the AMI set), setting the status of the AMI set will currently fail and block the queue and the hydroponic (kill it).

Solution

When loading the AMI set to set the status log that the AMI set is no longer present instead of trying to call a method on NULL
@DiegoPino DiegoPino added bug Something isn't working Reporting Errors, Logs, etc. queue FIFO queue workers Ones taking the FI and doing the FO Release duty Things only a mad person should do labels Jun 26, 2023
@DiegoPino DiegoPino added this to the 0.5.0 milestone Jun 26, 2023
@DiegoPino DiegoPino self-assigned this Jun 26, 2023
@DiegoPino
Copy link
Member Author

Note: I was in the impression I had handled that edge case but a try/catch will not work with a NULL there. See

ami/src/Plugin/QueueWorker/IngestADOQueueWorker.php

Line 1123 in 486cec3

if ($ami_set->getStatus() != $status && $status!= amiSetEntity::STATUS_PROCESSING && !$finished) {

DiegoPino added a commit that referenced this issue Jun 26, 2023
@DiegoPino
Check for AMI existence. In case it was delete or exception log to DB
70c71b0 
This should cover the uncaught issue on #171
@DiegoPino DiegoPino mentioned this issue Jun 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DiegoPino DiegoPino

Labels
bug Something isn't working queue workers Ones taking the FI and doing the FO queue FIFO Release duty Things only a mad person should do Reporting Errors, Logs, etc.
Projects
None yet
Milestone
0.5.0
Development

No branches or pull requests
1 participant
@DiegoPino