Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility between Rebar3 and Erlang/OTP #2903

Open
kianmeng opened this issue Jun 25, 2024 · 6 comments · May be fixed by #2918
Open

Compatibility between Rebar3 and Erlang/OTP #2903

kianmeng opened this issue Jun 25, 2024 · 6 comments · May be fixed by #2918

Comments

@kianmeng
Copy link
Contributor

While cleaning up Erlang CI pipeline, I looked for a compatibility table between Rebar3 and Erlang/OTP, but couldn't find one. Therefore, I've compiled the following table based on the release changelog.

Rebar3 Erlang/OTP
3.23.x 25, 26, 27
3.22.x 25, 26, 27
3.21.x 24, 25, 26
3.20.x 23, 24, 25
3.19.x 23, 24, 25
3.18.x 20, 21, 22
Erlang/OTP Rebar3
27 3.23.x, 3.22,x
26 3.23.x, 3.22,x, 3.21.x
25 3.21.x, 3.20,x, 3.19.x
24 3.20.x, 3.19.x
23 3.19.x
22 3.18.x
21 3.15.x
20 3.15.x

Please let me know if the compatibility table above (not sure which one) is helpful as additional details to the README. I can then draft a pull request.

@paulo-ferraz-oliveira
Copy link
Contributor

This is definitely a plus, I've had this same issue in the past (trying to find a version compatible with a specific Erlang/OTP version range).

@kianmeng
Copy link
Contributor Author

@paulo-ferraz-oliveira Should we put this compatibility table in https://github.com/erlef/setup-beam instead here?

@paulo-ferraz-oliveira
Copy link
Contributor

paulo-ferraz-oliveira commented Jun 26, 2024

If it were just me choosing, I'd prefer to have it here, and then link from the action. As-is, there, we know about compatibility with the targets (mostly OTP) because of the way it's "documented" in the sources.

Edit: if this doesn't move here, or is rejected (either way I'm pretty sure you'll have follow-up) feel free to open an issue there (erlef/setup-beam), for further discussion (I believe we discussed it in the past, but can't remember and a quick search in the issues yielded no interesting results).

@ferd
Copy link
Collaborator

ferd commented Jul 2, 2024

I don't see an issue with this.

It might be worth it to make sure the table considers past security issues and does not recommend versions older than these.

Basically, any release older than these are unsafe for any version whatsoever:

So in the tables above. 3.15.x is risky. It should be 3.15.2 explicitly because 3.15.0 and 3.15.1 had major vulnerabilities.

All other versions in the table are above this and not a concern.

weiss added a commit to weiss/textgroup that referenced this issue Jul 31, 2024
@paulo-ferraz-oliveira
Copy link
Contributor

Yeah, the table could be:

rebar3 OTP support range Notes
3.16.1 22-24
3.15.2 19.23 ✅ (note: don't use 3.15.0 or 3.15.1
3.13.3 19-22

kianmeng added a commit to kianmeng/rebar3 that referenced this issue Sep 25, 2024
@kianmeng kianmeng linked a pull request Sep 25, 2024 that will close this issue
@kianmeng
Copy link
Contributor Author

@ferd @paulo-ferraz-oliveira Sorry, totally forgotten about the discussion. PR submitted, #2918

kianmeng added a commit to kianmeng/rebar3 that referenced this issue Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants