Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tests run on rhel8 #66

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Make tests run on rhel8 #66

merged 1 commit into from
Mar 13, 2024

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Mar 7, 2024 •
edited
Loading

Resolves #65

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@larsevj larsevj force-pushed the test_also_with_py311_komodo branch 3 times, most recently from 4fecab2 to d27947f Compare March 12, 2024 09:38
@larsevj larsevj changed the title Test also with py311 komodo Make tests run on rhel8 as well Mar 12, 2024
@larsevj larsevj changed the title Make tests run on rhel8 as well Make tests run on rhel8 Mar 12, 2024
@larsevj larsevj force-pushed the test_also_with_py311_komodo branch from d27947f to 3a815a1 Compare March 12, 2024 14:31
andreas-el
andreas-el reviewed Mar 13, 2024
View reviewed changes
tests/conftest.py Outdated Show resolved Hide resolved
andreas-el
andreas-el reviewed Mar 13, 2024
View reviewed changes
tests/test_main.py Outdated Show resolved Hide resolved
@larsevj larsevj requested a review from andreas-el March 13, 2024 10:42
andreas-el
andreas-el approved these changes Mar 13, 2024
View reviewed changes
Copy link

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🚀

@larsevj larsevj force-pushed the test_also_with_py311_komodo branch from d4fc280 to 7198769 Compare March 13, 2024 11:28
@larsevj larsevj merged commit f052b40 into main Mar 13, 2024
6 checks passed
@larsevj larsevj deleted the test_also_with_py311_komodo branch March 13, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreas-el andreas-el andreas-el approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run tests also with python3.11
2 participants
@larsevj @andreas-el