Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning from {lintr} workflow in [namespace_lintr] #119

Open
avallecam opened this issue Feb 1, 2024 · 6 comments
Open

warning from {lintr} workflow in [namespace_lintr] #119

avallecam opened this issue Feb 1, 2024 · 6 comments

Comments

@avallecam
Copy link
Member

avallecam commented Feb 1, 2024

In #104 from workflow in https://github.com/epiverse-trace/tutorials/actions/runs/7699737505/job/20982024773?pr=104 to line:

```{r}
epiparameter::epidist_db(
disease = "covid"
)

I'm getting this {lintr} warning

Warning: file=read-delays.Rmd,line=188,col=1,[namespace_linter] Package 'epiparameter' is not installed.

Some thoughts:

tagging @Bisaloo since this is related with #96

@Bisaloo
Copy link
Member

Bisaloo commented Feb 1, 2024

It looks like epiparameter and epidemics and not properly installed during the lintr check. I'll look into it.

2024-02-01T11:11:48.6709022Z Skipping 2 packages not available: epiparameter, epidemics

@avallecam
Copy link
Member Author

avallecam commented Feb 2, 2024

thank you @Bisaloo this is the only lintr pending to pass for #104 as in this last run https://github.com/epiverse-trace/tutorials/actions/runs/7754598773/job/21148236369?pr=104

the list of packages highlighted as sources of warning are:

  • {epiparameter}
  • {here} (recently added in favour of using portable paths)
  • {outbreaks}

@avallecam
Copy link
Member Author

also only lintr pending to pass in #58 as in last run https://github.com/epiverse-trace/tutorials/actions/runs/7755166483/job/21149968993?pr=58

package highlighted is {here}

@avallecam
Copy link
Member Author

avallecam commented Feb 2, 2024

@Bisaloo, in order to give it more time to investigate the source of the issue, we can temporarily replace namespace::function() with library(package) followed by function() to achieve the goal of ready to merge this week. Happy to read your thoughts.

@Bisaloo
Copy link
Member

Bisaloo commented Feb 2, 2024

The simplest option at this time is probably to disable this linter altogether by editing the .lintr file with the following content:

linters: all_linters(
    packages = "lintr",
    object_name_linter = NULL,
    implicit_integer_linter = NULL,
    brace_linter = NULL,
    extraction_operator_linter = NULL,
    missing_package_linter = NULL,
    library_call_linter = NULL,
    namespace_linter = NULL,
    undesirable_function_linter(
      modify_defaults(
        default_undesirable_functions,
        library = NULL # this is fine in Rmd files
      )
    )
  )

@avallecam
Copy link
Member Author

avallecam commented Feb 2, 2024

got it, just found the .lintr file! I can proceed by:

but keeping this issue open for further investigation or decision.

happy to read your suggestions about this

avallecam added a commit that referenced this issue Feb 2, 2024
following suggestion in #119 (comment)
avallecam added a commit that referenced this issue Feb 2, 2024
following suggestion in #119 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants