Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return complexity_limit in cyclocomp_linter to 15L #196

Closed
sbfnk opened this issue Jan 29, 2024 · 0 comments · Fixed by #197
Closed

Return complexity_limit in cyclocomp_linter to 15L #196

sbfnk opened this issue Jan 29, 2024 · 0 comments · Fixed by #197

Comments

@sbfnk
Copy link
Contributor

sbfnk commented Jan 29, 2024

This was changed to 25L to accommodate the (possibly unavoidable) cyclomatic complexity of simulate_chains() introduced in #171

However, in light of the discussion in #179 I think it might be better to keep the limit at 15L and only exclude simulate_chains() by wrapping it in a # nolint start: cyclocomp_lintr and corresponding nolint end block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant