Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relative links in README #659

Closed
sbfnk opened this issue May 8, 2024 · 2 comments · Fixed by #653
Closed

Relative links in README #659

sbfnk opened this issue May 8, 2024 · 2 comments · Fixed by #653
Milestone
CRAN v1.5 release

Comments

@sbfnk
Copy link
Contributor

sbfnk commented May 8, 2024

These trigger NOTEs which we'll need to minimise for CRAN submission.
#652 (comment)
@sbfnk sbfnk added this to the CRAN v1.5 release milestone May 8, 2024
@jamesmbaazam
Copy link
Contributor

Two options here:

@sbfnk
Copy link
Contributor Author

sbfnk commented May 8, 2024

  • Not hyperlinked.

This seems like the more sensible option to me, so as not to confuse people between dev/stable version docs.

@sbfnk sbfnk linked a pull request May 8, 2024 that will close this issue
1.5.0 release PR #653
Merged
7 tasks
sbfnk added a commit that referenced this issue May 8, 2024
@sbfnk
remove relative links
21f7b39 
closing #659
sbfnk added a commit that referenced this issue May 10, 2024
@sbfnk
1.5.0 release PR (#653)
08d7958 
* update version in NEWS

* fix typos

* update vignettes

* clean up imports

* donttest in estimate_truncation example

* fix links

* update namespace

* first version of cran comments

* reorder news by priority

* update package man page

* add mantainer to cran comment

* re-render README

* Increment version number to 1.5.0

* remove relative links

closing #659

* streamline vignettes and move figures

Closes #660

* backtick escape stanfit object

Closes #661.

* write executable to temporary directory

Closes #662.

* reformat for linting

* update cran comments

* remove test

this is causing warnings and is only a deprecation test so easiest to just remove

* don't write into user directory

* set seed in vignettes

* update cran comments

* dev version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
CRAN v1.5 release
Development

Successfully merging a pull request may close this issue.

1.5.0 release PR epiforecasts/EpiNow2
2 participants
@sbfnk @jamesmbaazam