Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render issue with horizontal gutters #16

Open
psybers opened this issue Apr 8, 2024 · 2 comments
Open

Render issue with horizontal gutters #16

psybers opened this issue Apr 8, 2024 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@psybers
Copy link

psybers commented Apr 8, 2024

All of the sample labels are Avery brand, where there are no horizontal gutters (each label touches the one above/below it). So it was not obvious that there is a rendering bug.

What happens is if you set a horizontal gutter, it will allocate space above the first label. Thus, it artificially inflates the top margin.

For example, this was the settings I used for these labels (https://www.amazon.com/dp/B014IPO0US):

    "royalgreen1660": LabelInfo(
        labels_horizontal=7,
        labels_vertical=22,
        label_size=(25.4 * mm, 9.52 * mm),
        gutter_size=(2.5 * mm, 2.5 * mm),
        margin=(11.55 * mm, (8.73 - 2.5) * mm),
        pagesize=LETTER,
    ),

Note that I had to do 8.73 - 2.5 (subtract out the horizontal gutter height) to get it right.

@jcgruenhage
Copy link
Member

A PR for this would be highly appreciated!

@jcgruenhage jcgruenhage added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants