Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate code examples under /api from JS to TS #530

Open
alansemenov opened this issue May 30, 2024 · 2 comments · May be fixed by #531
Open

Migrate code examples under /api from JS to TS #530

alansemenov opened this issue May 30, 2024 · 2 comments · May be fixed by #531
Assignees
@ComLock

Comments

@alansemenov
Copy link
Member

https://developer.enonic.com/docs/xp/stable/api

For all libs under /api:

  • replace page title from "X Library" to "X API"
  • remove "Javascript" from "in your JavaScript controller"
  • replace require with import
  • make sure there are no var left after the change
  • demonstrate usage of types where applicable
@ComLock
Copy link
Member

ComLock commented Sep 11, 2024

@alansemenov should anonymous functions (that doesn't use this) be converted to fat arrow functions?

ComLock added a commit that referenced this issue Sep 11, 2024
@ComLock
Fix #530 Migrate code examples under /api from JS to TS
044a18c
@ComLock ComLock linked a pull request Sep 11, 2024 that will close this issue
530 migrate code examples under api from js to ts #531
Open
@alansemenov
Copy link
Member Author

@alansemenov should anonymous functions (that doesn't use this) be converted to fat arrow functions?

yes 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ComLock ComLock

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

530 migrate code examples under api from js to ts enonic/doc-xp
2 participants
@ComLock @alansemenov