Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to define internal_address_config envoy config #5713

Open
dbonf opened this issue Jul 1, 2024 · 0 comments
Open

ability to define internal_address_config envoy config #5713

dbonf opened this issue Jul 1, 2024 · 0 comments
Labels
t:feature New feature or enhancement request

Comments

@dbonf
Copy link

dbonf commented Jul 1, 2024

Please describe your use case / problem.

We expose emissary to public internet requests as well as requests from untrusted private IPs (e.g. coming from customers private links), the ones coming from private links are marked as private (X-Envoy-Internal: true and no X-Envoy-External-Address defined) because by default internal_address_config corresponds to RFC1918 IP addresses, this is not what we want, as those private IP customer requests are not really internal.

Describe the solution you'd like
We want internal_address_config to be user configurable, a thing that at the moment is not possible.

Describe alternatives you've considered
LUA scripts to add the header manipulations that comes free with envoy, it if could be configurable.

Additional context
This is not the first time we encounter a limitation on emissary ingress on low level configuration of envoy, see for example requests for other needs like #4606, or, always coming from our needs, the ability to configure this extension, if possible we would like to have a general way to reach and freely configure the underling envoy proxy.

@dosubot dosubot bot added the t:feature New feature or enhancement request label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:feature New feature or enhancement request
Projects
None yet
Development

No branches or pull requests

1 participant