From 23728e145ec52bd1193f6f0123973763de4dbb3d Mon Sep 17 00:00:00 2001 From: rustbasic <127506429+rustbasic@users.noreply.github.com> Date: Thu, 10 Oct 2024 22:51:52 +0900 Subject: [PATCH] Fix bug causing wrong-fire of `ViewportCommand::Visible` (#5244) Fix: variable name issue I'm not sure, if there's any particular reason to do `self.active` . I thought `self.visible` was the original intention. --- crates/egui/src/viewport.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/egui/src/viewport.rs b/crates/egui/src/viewport.rs index e685d3ee6b7..df72f822d4d 100644 --- a/crates/egui/src/viewport.rs +++ b/crates/egui/src/viewport.rs @@ -728,7 +728,7 @@ impl ViewportBuilder { } if let Some(new_visible) = new_visible { - if Some(new_visible) != self.active { + if Some(new_visible) != self.visible { self.visible = Some(new_visible); commands.push(ViewportCommand::Visible(new_visible)); }