Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirm to have tests equivalent with embulk-core #33

Open
10 of 13 tasks
dmikurube opened this issue Mar 1, 2019 · 0 comments
Open
10 of 13 tasks

Confirm to have tests equivalent with embulk-core #33

dmikurube opened this issue Mar 1, 2019 · 0 comments

Comments

@dmikurube
Copy link
Member

dmikurube commented Mar 1, 2019 •
edited
Loading

Java src/test/java

  • org/embulk/config/TestConfigSource.java
    • Including some tests w/ TimestampParser, but just using.
  • org/embulk/spi/time/TestRubyTimeFormat.java
    • Same tests in org/embulk/util/rubytime/TestFormat.java
  • org/embulk/spi/time/TestTimeZoneIds.java
    • Most regional timezones (ex. Asia/Taipei) are not supported in embulk-util-rubytime.
    • Some are tested in org/embulk/util/rubytime/TestTimeZones.java.
    • To be tested with LegacyEmbulkZones.java on the Embulk side.
  • org/embulk/spi/time/TestTimestamp.java
    • Timestamp is Embulk's original class.
    • Not tested in embulk-util-rubytime.
  • org/embulk/spi/time/TestTimestampFormatter.java
    • Formatter is not implemented yet.
    • Not tested in embulk-util-rubytime.
  • org/embulk/spi/time/TestTimestampFormatterParser.java
    • It consists of tests as org.embulk.spi.Timestamp.
    • Not tested in embulk-util-rubytime.
  • org/embulk/spi/time/TestTimestampParser.java
    • These tests are to be imported.
  • org/embulk/spi/time/TestTimestampSerDe.java
    • These tests are just for SerDe.
    • Not tested in embulk-util-rubytime.

Ruby src/test/ruby

  • monkey_strptime/mri/date/test_date_strptime.rb
    • Tested with org/embulk/util/rubytime/TestRubyDateTimeFormatterParseWithJRuby.java and src/test/resources/ruby/test/date/test_date_strptime.rb
  • vanilla/test_schema.rb
    • Not to be tested in embulk-util-rubytime.
  • vanilla/guess/test_schema_guess.rb
    • Not to be tested in embulk-util-rubytime.
  • vanilla/guess/test_time_format_guess.rb
    • Not to be tested in embulk-util-rubytime.
  • vanilla/time/test_timestamp_parser.rb
    • Some are identical with test_date_strptime.rb, but need to be investigated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmikurube